[U-Boot] [PATCH] post: add gpio hotkey support

Mike Frysinger vapier at gentoo.org
Thu May 12 17:08:25 CEST 2011


On Thursday, May 12, 2011 08:47:56 Sergei Shtylyov wrote:
> On 11-05-2011 18:54, Mike Frysinger wrote:
> >>>    int __post_hotkeys_pressed(void)
> >>>    {
> >>> +#ifdef CONFIG_SYS_POST_HOTKEYS_GPIO
> >>> +	return ret;
> >>> +#endif
> >>> 
> >>      You surely meant #else here?
> >>> 
> >>>    	return 0;	/* No hotkeys supported */
> > 
> > not really what i was going for.  it's fine either way though.
> 
>     I don't think 2 returns in a row is fine...

if there were no CPP here, then obviously you'd be right.  but there is, and i 
dont see much point now in adding a little more wrapping.  gcc doesnt warn 
about it.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110512/d9f86960/attachment.pgp 


More information about the U-Boot mailing list