[U-Boot] [PATH v7 2/2] Add support for Network Space v2

[Wolfgang Denk]

Dear Simon Guinot,

In message <20110512114727.GC6693 at kw.sim.vm.gnt> you wrote:
> 
> > > +#define CONFIG_IDENT_STRING          " LaCie Network Space v2"
> > > +#elif defined(CONFIG_NETSPACE_MAX_V2)
> > > +#define CONFIG_MACH_TYPE             MACH_TYPE_NETSPACE_MAX_V2
> > > +#define CONFIG_IDENT_STRING          " LaCie Network Space Max v2"
> > > +#endif
> > 
> > There should be #elif for third board and #error for #else part
>
> I have noticed this #error in the other board include files. Is it
> really needed ? This file is only included if one machine is selected.

Defensive programming is a Good Thing.  Today you remember that there
are only three boards. Next year somebody adds another one and fails
to update all relevant places.

> > > +#define CONFIG_CMD_EXT2
> > > +#define CONFIG_CMD_FAT
> > 
> > Get rid of this, use CONFIG_SYS_MVFS
>
> Outch. Please no :)

Agreed. Leave as is.

> > > +     "ipaddr=192.168.1.111\0"                        \
> > 
> > NAK for ipaddr, no ip address should be defined by default.
>
> I understand, but I need a known IP address.
>
> I want people to be able to update the stock U-Boot using netconsole
> (without a serial link which require to open the case). At restart,
> right after the update, a user must be able to figure out the board IP.
>
> An alternative could be using a DHCP configuration.

Yes, that would be much better.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It is easier to change the specification to fit the program than vice
versa.