[U-Boot] [PATCH v2 3/6] TFTP: rename "server" to "remote"

Luca Ceresoli luca.ceresoli at comelit.it
Sat May 14 18:07:36 CEST 2011


Luca Ceresoli wrote:
> Hi Wolfgang,
>
> Wolfgang Denk wrote:
>> Dear Luca Ceresoli,
>>
>> In 
>> message<1303143594-5345-4-git-send-email-luca.ceresoli at comelit.it>  
>> you wrote:
>>> With the upcoming TFTP server implementation, the remote node can be
>>> either a client or a server, so avoid ambiguities.
>>>
>>> Signed-off-by: Luca Ceresoli<luca.ceresoli at comelit.it>
>>> Cc: Wolfgang Denk<wd at denx.de>
>>> ---
>>> Changes in v2:
>>>   - fixed checkpatch issues.
>>>
>>>   net/tftp.c |   42 +++++++++++++++++++++---------------------
>>>   1 files changed, 21 insertions(+), 21 deletions(-)
>> How do we proceed now?  I've applied paches 1 + 2 of this series,
>> but for patch 3 we had changes requested, and the following patche
>> sdepend on it.
>>
>> I understand you are now waiting for the "net/net.c: cosmetic:"
>> patches to go in?  Normally these would be stuff for the next
>> branch...
>>
>> I'd even be willing to pull these in now, if you then would re-post
>> the remaining patches of the tftpserver code soon?
>
> I see you've committed the net/net.c cleanup into master.
> I'll rebase the TFTP server work (only patches 3 and 4) and resend them
> as soon as possible for inclusion in master, perhaps today or tomorrow.
>

Damn. While rebasing, I hit many checkpatch issues. The cleanup soon became
larger that the TFTP server work, so I took a breath, and started a new 
branch
out of master to fully cleanup net/tftp.c.

I submitted right now a lengthy patch series just for that cleanup.
Since it's very similar to my net/net.c cleanup that has just been 
merged, I think
this will be merged also without a great need of discussion.

I'll take some time ASAP to rebase the TFTP server on top of this cleanup,
but alas not today nor tomorrow (I spent all the time with checkpatch...).

Luca



More information about the U-Boot mailing list