[U-Boot] [PATCH v8] Add support for Network Space v2 and parents

Wolfgang Denk wd at denx.de
Sun May 15 14:45:19 CEST 2011


Dear Simon Guinot,

In message <1305462738-2583-1-git-send-email-simon.guinot at sequanux.org> you wrote:
> --===============0038591950==
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> This patch add support for the Network Space v2 board and parents, based
> on the Marvell Kirkwood 6281 SoC. This include Network Space (Max) v2
> and Internet Space v2.
> 
> Additional information is available at:
> http://lacie-nas.org/doku.php?id=network_space_v2
> 
> Signed-off-by: Simon Guinot <sguinot at lacie.com>
> ---
> Changes for v2:
>   - add entries to MAINTAINERS file
>   - move boards from root Makefile to boards.cfg
>   - move MACH_TYPE definition into netspace_v2.h
>   - remove CONFIG_SYS_HZ redefinition
>   - turn PHY initialization message into debug()
> 
> Changes for v3: none
> 
> Changes for v4:
>   - enhance commit message: add SoC information
> 
> Changes for v5: none
> 
> Changes for v6:
>   - enable device tree support
>   - clean some "#define" in netspace_v2.h
>   - enhance commit message: provide description URL and mention SoC
>     family
>   - rebase against u-boot-{arm,marvell}/master branches
> 
> Changes for v7:
>   - rebase against u-boot-marvell/master branch
> 
> Changes for v8:
>   - update commit title (add netspace_v2 parents information).
>   - move GPIO button definition into header file.
>   - update CONFIG_IDENT_STRING with boards alias.
>   - handle wrong board definition.
>   - by default, use DHCP to get IP address.
> 
>  MAINTAINERS                           |    6 +
>  board/LaCie/netspace_v2/Makefile      |   49 ++++++++++
>  board/LaCie/netspace_v2/kwbimage.cfg  |  162 +++++++++++++++++++++++++++++++++
>  board/LaCie/netspace_v2/netspace_v2.c |  142 +++++++++++++++++++++++++++++
>  board/LaCie/netspace_v2/netspace_v2.h |   42 +++++++++
>  boards.cfg                            |    3 +
>  include/configs/netspace_v2.h         |  162 +++++++++++++++++++++++++++++++++
>  7 files changed, 566 insertions(+), 0 deletions(-)
>  create mode 100644 board/LaCie/netspace_v2/Makefile
>  create mode 100644 board/LaCie/netspace_v2/kwbimage.cfg
>  create mode 100644 board/LaCie/netspace_v2/netspace_v2.c
>  create mode 100644 board/LaCie/netspace_v2/netspace_v2.h
>  create mode 100644 include/configs/netspace_v2.h

What the hell is this?  Is this supposed to be a reposting of your
earlier patches?  Or what??  But hey, why is each and every patch
version different, then?


So we have three patches now, which - according to your changelogs -
are supposed to be identical:

 8522  05/14 Simon Guinot       [U-Boot] [PATCH] Add support for Network Space v2 and parents
             http://article.gmane.org/gmane.comp.boot-loaders.u-boot/99745
 8523  05/14 Simon Guinot       [U-Boot] [PATCH v8] Add support for Network Space v2 and parents
             http://article.gmane.org/gmane.comp.boot-loaders.u-boot/99746
 8554  05/15 Simon Guinot       [U-Boot] [PATCH v8] Add support for Network Space v2 and parents
             http://article.gmane.org/gmane.comp.boot-loaders.u-boot/99771

diff 8522 8523:

111c115
<   - update commit title (add 'parents' information).
---
>   - update commit title (add netspace_v2 parents information).
115,116c119,120
<   - by default, use DHCP to get an IP address.
<  
---
>   - by default, use DHCP to get IP address.
> 


diff 8523 8554:

575,577c576
< @@ -104,6 +104,9 @@ davinci_schmoogie            arm         arm926ejs   schmoogie           davinci
<  davinci_sffsdr               arm         arm926ejs   sffsdr              davinci        davinci
<  davinci_sonata               arm         arm926ejs   sonata              davinci        davinci
---
> @@ -106,6 +106,9 @@ davinci_sonata               arm         arm926ejs   sonata              davinci
578a578,579
>  suen8                        arm         arm926ejs   km_arm              keymile        kirkwood
>  mgcoge2un                    arm         arm926ejs   km_arm              keymile        kirkwood


Why is each of your (uncommented) respostings different to the
previous one???

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Ever try. Ever fail. No matter. Try again. Fail again.  Fail  better.
                                                        -- S. Beckett


More information about the U-Boot mailing list