[U-Boot] [PATCH v3 03/10] armv7: cache maintenance operations for armv7

[Wolfgang Denk]

Dear Aneesh V,

In message <1305202276-27784-4-git-send-email-aneesh at ti.com> you wrote:
> - Add a framework for layered cache maintenance
> 	- separate out SOC specific outer cache maintenance from
> 	  maintenance of caches known to CPU
> 
> - Add generic ARMv7 cache maintenance operations that affect all
>   caches known to ARMv7 CPUs. For instance in Cortex-A8 these
>   opertions will affect both L1 and L2 caches. In Cortex-A9
>   these will affect only L1 cache
> 
> - D-cache operations supported:
> 	- Invalidate entire D-cache
> 	- Invalidate D-cache range
> 	- Flush(clean & invalidate) entire D-cache
> 	- Flush D-cache range

How much of this is actually needed in the context of U-Boot?

...
> +	for (way = num_ways - 1; way >= 0 ; way--)
> +		for (set = num_sets - 1; set >= 0; set--) {
> +			setway = (level << 1) | (set << log2_line_len) |
> +				 (way << way_shift);
> +			/* Invalidate data/unified cache line by set/way */
> +			asm volatile ("	mcr p15, 0, %0, c7, c6, 2"
> +					: : "r" (setway));
> +		}

Braces needed for multiline for().  Please fix globally.

...
> +	if (operation == ARMV7_DCACHE_INVAL_ALL)
> +		v7_inval_dcache_level_setway(level, num_sets, num_ways,
> +				      way_shift, log2_line_len);
> +	else if (operation == ARMV7_DCACHE_CLEAN_INVAL_ALL)
> +		v7_clean_inval_dcache_level_setway(level, num_sets, num_ways,
> +						   way_shift, log2_line_len);

Braces needed for multiline statements.  Please fix globally.

> +	for (mva = start; mva < stop; mva = mva + line_len)
> +		/* DCCIMVAC - Clean & Invalidate data cache by MVA to PoC */
> +		asm volatile ("mcr p15, 0, %0, c7, c14, 1" : : "r" (mva));

And again etc. etc. 

...
> +void invalidate_dcache_all(void)
> +{
> +}
> +
> +void flush_dcache_all(void)
> +{
> +}
> +
> +void invalidate_dcache_range(unsigned long start, unsigned long stop)
> +{
> +}
> +
> +void flush_dcache_range(unsigned long start, unsigned long stop)
> +{
> +}
> +
> +void arm_init_before_mmu(void)
> +{
> +}
> +
> +void  flush_cache(unsigned long start, unsigned long size)
> +{
> +}

Please do not add dead code.  I consider it misleading to have
functions which promise to perform something, and actually do nothing.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Gods don't like people not doing much work. People  who  aren't  busy
all the time might start to _think_.  - Terry Pratchett, _Small Gods_