[U-Boot] [PATCH v2 10/22] omap4: utility function to identify the context of hw init

[Wolfgang Denk]

Dear Aneesh V,

In message <1305472900-4004-11-git-send-email-aneesh at ti.com> you wrote:
> The basic hardware init of OMAP4(s_init()) can happen in 4
> different contexts:
>  1. SPL running from SRAM
>  2. U-Boot running from FLASH
>  3. Non-XIP U-Boot loaded to SDRAM by SPL
>  4. Non-XIP U-Boot loaded to SDRAM by ROM code using the
>     Configuration Header feature
...
> +	if (uboot_loaded_by_spl())
> +		return OMAP_INIT_CONTEXT_UBOOT_LOADED_BY_SPL;
> +	else if (running_from_sdram())
> +		return OMAP_INIT_CONTEXT_UBOOT_LOADED_BY_CH;

For reasons of consistency, should this not better be
OMAP_INIT_CONTEXT_UBOOT_LOADED_BY_ROM ?

> +		return OMAP_INIT_CONTEXT_XIP_UBOOT;

What exactly is OMAP_INIT_CONTEXT_XIP_UBOOT?

Do you mean the situation when booting from NOR flash, before
relocation?

Eventually the "loaded by" definition is not so good, as it does not
really cover the NOR boot case.


> +/* HW Init Context */
> +#define OMAP_INIT_CONTEXT_SPL			0
> +#define OMAP_INIT_CONTEXT_XIP_UBOOT		1
> +#define OMAP_INIT_CONTEXT_UBOOT_LOADED_BY_SPL	2
> +#define OMAP_INIT_CONTEXT_UBOOT_LOADED_BY_CH	3

Boot from NOR?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The Buddha, the Godhead, resides quite as comfortably in the circuits
of a digital computer or the gears of a cycle transmission as he does
at the top of a mountain or in the petals of a flower.
            - R.  Pirsig, "Zen and the Art of Motorcycle Maintenance"