[U-Boot] [PATCH v2 20/22] omap: spl: add FAT support over MMC

[Wolfgang Denk]

Dear Aneesh V,

In message <1305472900-4004-21-git-send-email-aneesh at ti.com> you wrote:
> Signed-off-by: Aneesh V <aneesh at ti.com>
> ---
> V2:
>  * Changes for make file changes
> ---
>  include/configs/omap4_sdp4430.h |    1 +
>  spl/board/ti/omap4.mk           |    7 +++++++
>  spl/board/ti/spl-omap.c         |   22 ++++++++++++++++++++++
>  3 files changed, 30 insertions(+), 0 deletions(-)
...
> +	err = file_fat_read("u-boot.bin", (u8 *)CONFIG_SYS_TEXT_BASE, 0);

Please do not hard code the file name here.   Keep the code flexible
and allow for other possibilities, too.  At the very least, make this
compile-time selectable.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A quarrel is quickly settled when deserted by one party; there is  no
battle unless there be two.                                  - Seneca