[U-Boot] [PATCH v2 21/22] omap4: add spl support for OMAP4 Panda

[Wolfgang Denk]

Dear Aneesh V,

In message <1305472900-4004-22-git-send-email-aneesh at ti.com> you wrote:
> Signed-off-by: Aneesh V <aneesh at ti.com>
> ---
> V2:
>  * Changed CONFIG_SYS_SPL_TEXT_BASE to 0x40304350 for Panda
>    This is required for EMU devices
>  * Changes due to make file changes
> ---
>  arch/arm/cpu/armv7/omap4/emif.c        |    5 +++--
>  arch/arm/include/asm/arch-omap4/emif.h |   10 +++++-----
>  include/configs/omap4_panda.h          |   24 ++++++++++++++++++++++++
>  spl/board/ti/panda/Makefile            |   32 ++++++++++++++++++++++++++++++++
>  4 files changed, 64 insertions(+), 7 deletions(-)
>  create mode 100644 spl/board/ti/panda/Makefile
> 
> diff --git a/arch/arm/cpu/armv7/omap4/emif.c b/arch/arm/cpu/armv7/omap4/emif.c
> index b09aa8f..699a545 100644
> --- a/arch/arm/cpu/armv7/omap4/emif.c
> +++ b/arch/arm/cpu/armv7/omap4/emif.c
> @@ -1178,9 +1178,9 @@ static void dmm_init(u32 base)
>  #ifdef CONFIG_SYS_EMIF_PRECALCULATED_TIMING_REGS
>  	emif_get_dmm_regs(&lisa_map_regs);
>  #else
> -	u32 emif1_size, emif2_size, mapped_size, section_map;
> +	u32 emif1_size, emif2_size, mapped_size, section_map = 0;
>  	u32 section_cnt, sys_addr;
> -	struct dmm_lisa_map_regs lis_map_regs_calculated;
> +	struct dmm_lisa_map_regs lis_map_regs_calculated = {0};

This iseems to be an unrelated change.  Please split into separate
patch.

>  	mapped_size = 0;
>  	section_cnt = 3;
> @@ -1253,6 +1253,7 @@ static void dmm_init(u32 base)
>  		lis_map_regs_calculated.dmm_lisa_map_2 = section_map;
>  		lis_map_regs_calculated.dmm_lisa_map_1 = 0;
>  	}
> +

Ditto.

>  	/* TRAP for invalid TILER mappings in section 0 */
>  	lis_map_regs_calculated.dmm_lisa_map_0 = DMM_LISA_MAP_0_INVAL_ADDR_TRAP;
>  
> diff --git a/arch/arm/include/asm/arch-omap4/emif.h b/arch/arm/include/asm/arch-omap4/emif.h
> index 8cc3230..b95e545 100644
> --- a/arch/arm/include/asm/arch-omap4/emif.h
> +++ b/arch/arm/include/asm/arch-omap4/emif.h
> @@ -520,11 +520,11 @@
>  
>  /* Trap for invalid TILER PAT entries */
>  #define DMM_LISA_MAP_0_INVAL_ADDR_TRAP		(\
> -		(0  << OMAP44XX_SDRC_ADDR_SHIFT) |\
> -		(DMM_SDRC_MAP_EMIF1_ONLY << OMAP44XX_SDRC_MAP_SHIFT)|\
> -		(DMM_SDRC_ADDR_SPC_INVALID << OMAP44XX_SDRC_ADDRSPC_SHIFT)|\
> -		(DMM_SDRC_INTL_NONE << OMAP44XX_SDRC_INTL_SHIFT)|\
> -		(0xFF << OMAP44XX_SYS_ADDR_SHIFT))
> +	(0  << OMAP44XX_SDRC_ADDR_SHIFT) |\
> +	(DMM_SDRC_MAP_EMIF1_ONLY << OMAP44XX_SDRC_MAP_SHIFT)|\
> +	(DMM_SDRC_ADDR_SPC_INVALID << OMAP44XX_SDRC_ADDRSPC_SHIFT)|\
> +	(DMM_SDRC_INTL_NONE << OMAP44XX_SDRC_INTL_SHIFT)|\
> +	(0xFF << OMAP44XX_SYS_ADDR_SHIFT))

Ditto.

...
> +++ b/spl/board/ti/panda/Makefile
> @@ -0,0 +1,32 @@
...
> +include $(SRCTREE)/spl/board/$(VENDOR)/omap4.mk
> +include $(SRCTREE)/spl/board/$(VENDOR)/rules-omap.mk

NAK, see previous messages.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If a train station is a place where a train stops,
                                           then what's a workstation?