[U-Boot] [PATCH v2 04/22] omap4: save parameters passed by ROM code to SPL

[Aneesh V]

Hi Wolfgang,

On Monday 16 May 2011 12:44 AM, Wolfgang Denk wrote:
> Dear Aneesh V,
>
> In message<1305472900-4004-5-git-send-email-aneesh at ti.com>  you wrote:
>> Save boot device information passed by OMAP4 rom code
>>
>> ROM code in OMAP4 passes information such as the media from
>> which it picked up the first boot image(SPL in our case),
>> the mode(raw mode/FAT mode) etc.
>>
>> Save this information in SPL so that we can use the same media
>> and mode to bootload u-boot.
>>
>> Signed-off-by: Aneesh V<aneesh at ti.com>
> ...
>> +	/* Store the boot device in omap4_boot_device */
>> +	ldr     r2, [r0, #BOOT_DEVICE_OFFSET]	@ r1<- value of boot device
>> +	and	r2, #BOOT_DEVICE_MASK
>> +	ldr	r3, =omap4_boot_device
>> +	str     r2, [r3]			@ omap4_boot_device<- r1
>
> Why don't you use stadard global data here?

SPL has access to .data right from the beginning. Besides this is too
early. global data is not initialized yet.

best regards,
Aneesh