[U-Boot] [PATCH v2 01/22] mkimage: Add OMAP boot image support

[Mike Frysinger]

On Monday, May 16, 2011 06:28:40 Aneesh V wrote:
> On Monday 16 May 2011 08:25 AM, Mike Frysinger wrote:
> > On Sunday, May 15, 2011 21:52:53 Mike Frysinger wrote:
> >> On Sunday, May 15, 2011 11:21:19 Aneesh V wrote:
> >>> +static void omapimage_print_header(const void *ptr)
> >>> +{
> >>> +	struct ch_toc *toc = (struct ch_toc *)ptr;
> >> 
> >> you're casting away the void.  something is fundamentally broken here.
> > 
> > err, obviously i meant "const" instead of "void" ...
> 
> This is not my code.

you're submitting the patch with only your s-o-b on it.  that means you're 
responsible for it all.

>   static void omapimage_print_header(const void *ptr)
>   {
> -	struct ch_toc *toc = (struct ch_toc *)ptr;
> +	const struct ch_toc *toc =  (const struct ch_toc *)ptr;

drop the cast entirely ... this isnt C++ after all:
	const struct ch_toc *toc =  ptr;
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110516/715f6757/attachment.pgp