[U-Boot] [PATCH v2 3/6] TFTP: rename "server" to "remote"

Luca Ceresoli luca.ceresoli at comelit.it
Mon May 16 22:16:52 CEST 2011


Mike Frysinger wrote:
> On Monday, April 18, 2011 12:19:51 Luca Ceresoli wrote:
>> With the upcoming TFTP server implementation, the remote node can be
>> either a client or a server, so avoid ambiguities.
> the summary made me worried because i thought you were going to rename the env
> var "server" to "remote".  could you tweak the summary to avoid this ambiguity
> in what you're actually doing ?  how about:
> 	TFTP: use "remote" in local variable names instead of "server"

Improved commit message in v3.

>> -	    IPaddr_t ServerNet	= TftpServerIP&  NetOurSubnetMask;
>> +	    IPaddr_t ServerNet	= TftpRemoteIP&  NetOurSubnetMask;
> shouldnt that now be RemoteNet ?

Done for v3.

Luca



More information about the U-Boot mailing list