[U-Boot] [PATCH V2] MX31: Make get_reset_cause() static and drop unreachable code

Stefano Babic sbabic at denx.de
Tue May 17 13:51:20 CEST 2011


get_reset_cause() should not be exported. Drop code in the function
after return statement that can generate warnings due to unreachable code.

Signed-off-by: Stefano Babic <sbabic at denx.de>
Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
---
 arch/arm/cpu/arm1136/mx31/generic.c |    6 +-----
 1 files changed, 1 insertions(+), 5 deletions(-)

diff --git a/arch/arm/cpu/arm1136/mx31/generic.c b/arch/arm/cpu/arm1136/mx31/generic.c
index fccd2cd..4ebf38d 100644
--- a/arch/arm/cpu/arm1136/mx31/generic.c
+++ b/arch/arm/cpu/arm1136/mx31/generic.c
@@ -133,7 +133,7 @@ u32 get_cpu_rev(void)
 	return srev | 0x8000;
 }
 
-char *get_reset_cause(void)
+static char *get_reset_cause(void)
 {
 	/* read RCSR register from CCM module */
 	struct clock_control_regs *ccm =
@@ -144,16 +144,12 @@ char *get_reset_cause(void)
 	switch (cause) {
 	case 0x0000:
 		return "POR";
-		break;
 	case 0x0001:
 		return "RST";
-		break;
 	case 0x0002:
 		return "WDOG";
-		break;
 	case 0x0006:
 		return "JTAG";
-		break;
 	default:
 		return "unknown reset";
 	}
-- 
1.7.1



More information about the U-Boot mailing list