[U-Boot] [PATCH 2/3] omap4: add support for EHCI

[Gilles Chanteperdrix]

On 05/18/2011 09:50 PM, John Rigby wrote:
> On Mon, May 9, 2011 at 3:04 PM, Gilles Chanteperdrix
> <gilles.chanteperdrix at xenomai.org> wrote:
> 
>> diff --git a/drivers/usb/host/ehci-omap4.c b/drivers/usb/host/ehci-omap4.c
>> new file mode 100644
>> index 0000000..19cd286
>> --- /dev/null
>> +++ b/drivers/usb/host/ehci-omap4.c
>> @@ -0,0 +1,268 @@
>> +/*
>> + * OMAP4 EHCI port, copied from linux/drivers/usb/host/ehci-omap.c
> So the file in linux is for both omap[34] yet here in u-boot it is
> only for omap4.  I admittedly know very little about EHCI internals
> but it seems to me that it would be nice if this could support both in
> u-boot.
> 
> I see from git history that omap3 support went in some months ago with
> only some new routines in beagle.c and no new usb files so could some
> omap usb expert explain.

I am far from an expert. But I saw a previous post for EHCI on omap3
saying "this file is sufficiently specific to be specific for each
board". So, I started writing a panda specific board, but found that
there was not really much code specific to panda, and most of the code
was specific to omap4.

This said, there is more than one way to do it on omap4, the processor
can be configured different ways to get EHCI support (as far as I
understood the processor even has two different EHCI controllers). So
maybe a panda-only file was not a bad idea after all...

-- 
                                                                Gilles.