[U-Boot] [PATCH v3 3/5] TFTP: net/tftp.c: add server mode receive

[Detlev Zundel]

Hi Luca,

> Signed-off-by: Luca Ceresoli <luca.ceresoli at comelit.it>
> Cc: Wolfgang Denk <wd at denx.de>

Acked-by: Detlev Zundel <dzu at denx.de>

Just for the future:

[...]

> diff --git a/net/tftp.h b/net/tftp.h
> index e3dfb26..3abdf7b 100644
> --- a/net/tftp.h
> +++ b/net/tftp.h
> @@ -2,6 +2,8 @@
>   *	LiMon - BOOTP/TFTP.
>   *
>   *	Copyright 1994, 1995, 2000 Neil Russell.
> + *	Copyright 2011 Comelit Group SpA
> + *	               Luca Ceresoli <luca.ceresoli at comelit.it>
>   *	(See License)
>   */
>  
> @@ -16,6 +18,10 @@
>  /* tftp.c */
>  extern void	TftpStart (void);	/* Begin TFTP get */
>  
> +#ifdef CONFIG_CMD_TFTPSRV
> +extern void	TftpStartServer(void);	/* Wait for incoming TFTP put */
> +#endif
> +
>  /**********************************************************************/
>  
>  #endif /* __TFTP_H__ */

I think we don't need the ifdefs in header files, or am I missing
something?  I _really_ like to avoid ifdefs wherever we can ;)

Cheers
  Detlev

-- 
I have a computer on which I can install any code I choose.  I don't
think that is a security flaw.  On the contrary, if only one company
can install a new version, that is a grave security flaw for me as a
user.      -- Richard Stallman <E1MJdJD-00010L-Gg at fencepost.gnu.org>
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de