[U-Boot] [PATCH] [Timer]Remove calls to [get, reset]_timer outside arch/

[Graeme Russ]

Hi Wolfgang,

On Tue, May 24, 2011 at 7:53 AM, Wolfgang Denk <wd at denx.de> wrote:
> Dear "J. William Campbell",
>
> In message <4DDAC866.1050508 at comcast.net> you wrote:
>>
>> > Is there any reason why we cannot silently perform a reset_timer() any time
>> > set_timer() is called with a parameter of 0?
>> Hi All,
>>       I assume you mean get_timer(0)?  In principle, you cannot do this
>> because it could be inside another get_timer(0) loop that has already
>> some time elapsed before you hit the inner get_timer(0). I think what
>> needs to happen on the old NIOS with 10 ms resolution on the interrupt
>> times is that all timer intervals must have 10 ms added and then rounded
>> up to the nearest multiple of 10. Thus, if you wanted to wait for 1
>> millisecond, you must use an argument of 20 ms to be sure you wait at
>> all! If you use an argument of 10, it won't help because you could get
>> an interrupt right away and exit. If these routines are nios2 specific,
>> you could add a local reset_timer, but I assume they are generic. . Note
>> that if these routines are not nios2 specific, is there any harm in
>> waiting "too long"?
>
> I think in the context of this rework get_timer() should be changed to
> take no argumen. Actually noe is needed, and if used as is now it can
> only cuse harm.
>

I think this might break stand alone applications - I am sure get_timer()
is exported. If not, sure, we can remove the argument, but that will be
a huge patch. If we do, we should change it from get_timer() to get_ms()
while we are at it

Regards,

Graeme