[U-Boot] [PATCH 2/4] [v2] nand_util: convert nand_write_skip_bad() to flags

[Ben Gardiner]

Hi Detlev,

On Tue, May 24, 2011 at 9:17 AM, Detlev Zundel <dzu at denx.de> wrote:
>> ---
>> Changes since v1:
>>  * rebased to HEAD of git://git.denx.de/u-boot-nand-flash.git : ff7b4a0
>>    ("env_nand: zero-initialize variable nand_erase_options")
>>  * renamed the flag from WITH_OOB to WITH_YAFFS_OOB (Detlev Zundel)
>>  * introduce 'WITH_DEFAULTS' flag defined as 0 so as to convert also
>>    the remaining nand_write_skip_bad() call (Detlev Zundel)
>
> I don't remember requesting this change - and rereading my mails I
> cannot find anything either.  Actually I consider this define to be
> overkill.  What I was asking for was to change all occurrences of the
> function call - a 0 for flags is ok with me.

Sorry. That was how I interpreted the following. My mistake.

On Fri, Apr 29, 2011 at 7:44 AM, Detlev Zundel <dzu at denx.de> wrote:
>> diff --git a/common/cmd_nand.c b/common/cmd_nand.c
>> index 7bd37de..69b2acc 100644
>> --- a/common/cmd_nand.c
>> +++ b/common/cmd_nand.c
>> @@ -581,7 +581,8 @@ int do_nand(cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
>>                               printf("Unknown nand command suffix '%s'.\n", s);
>>                               return 1;
>>                       }
>> -                     ret = nand_write_skip_bad(nand, off, &rwsize, (u_char *)addr, 1);
>> +                     ret = nand_write_skip_bad(nand, off, &rwsize,
>> +                                             (u_char *)addr, WITH_OOB);
>>  #endif
>>               } else if (!strcmp(s, ".oob")) {
>>                       /* out-of-band data */
>
> I see an occurrence of nand_write_skip_bad just above this if block.
> Please replace this also.

> If you remove that again, you can add my
>
> Acked-by: Detlev Zundel <dzu at denx.de>

Will do.

Thank you, Detlev.

,Ben Gardiner

---
Nanometrics Inc.
http://www.nanometrics.ca