[U-Boot] [PATCH 3/4] EHCI: adjust for mx5

[Igor Grinberg]

Hi Jana,

On 10/31/11 22:46, Jana Rapava wrote:
> 
> 
> 2011/10/31 Igor Grinberg <grinberg at compulab.co.il <mailto:grinberg at compulab.co.il>>
>  
> 
>     > +struct mxc_ulpi_regs {
>     > +     u8      vendor_id_low;          /* 0x00 - Vendor ID lower byte */
>     > +     u8      vendor_id_high;         /* 0x01 - Vendor ID upper byte */
>     > +     u8      product_id_low;         /* 0x02 - Product ID lower byte */
>     > +     u8      product_id_high;        /* 0x03 - Product ID higher byte */
>     > +     /* Function Control; 0x04 - 0x06 Read, 0x04 Write */
>     > +     u8      function_ctrl_write;
>     > +     u8      function_ctrl_set;      /* 0x05 Set */
>     > +     u8      function_ctrl_clear;    /* 0x06 Clear */
>     > +     /* Interface Control; 0x07 - 0x09 Read, 0x07 Write */
>     > +     u8      iface_ctrl_write;
>     > +     u8      iface_ctrl_set;         /* 0x08 Set */
>     > +     u8      iface_ctrl_clear;       /* 0x09 Clear */
>     > +     /* OTG Control; 0x0A - 0x0C Read, 0x0A Write */
>     > +     u8      otg_ctrl_write;
>     > +     u8      otg_ctrl_set;           /* 0x0B Set */
>     > +     u8      otg_ctrl_clear;         /* 0x0C Clear */
>     > +     /* USB Interrupt Enable Rising; 0x0D - 0x0F Read, 0x0D Write */
>     > +     u8      usb_ie_rising_write;
>     > +     u8      usb_ie_rising_set;      /* 0x0E Set */
>     > +     u8      usb_ie_rising_clear;    /* 0x0F Clear */
>     > +     /* USB Interrupt Enable Falling; 0x10 - 0x12 Read, 0x10 Write */
>     > +     u8      usb_ie_falling_write;
>     > +     u8      usb_ie_falling_set;     /* 0x11 Set */
>     > +     u8      usb_ie_falling_clear;   /* 0x12 Clear */
>     > +     u8      usb_int_status;         /* 0x13 - USB Interrupt Status */
>     > +     u8      usb_int_latch;          /* 0x14 - USB Interrupt Latch */
>     > +     u8      debug;                  /* 0x15 - Debug */
>     > +     /* Scratch Register; 0x16 - 0x18 Read, 0x16 Write */
>     > +     u8      scratch_write;
>     > +     u8      scratch_set;            /* 0x17 Set */
>     > +     u8      scratch_clear;          /* 0x18 Clear*/
>     > +};
> 
> 
>     These are the generic ULPI specification registers
>     and not mxc specific.
>     I'd expect to have them in a more generic location.
> 
> 
> This would be fixed in general ULPI support patch I'm working on. It should be ready for posting in a few days.

Good!
Still, I'd expect this to be put in a separate location.
This way, your general ULPI support patch will introduce
less changes to this file.
Submitting something and then moving it around is not
a good idea.

Another way would be to wait for the general ULPI support patch
and then resubmit this patch set on top of the ULPI patch.

You choose, what works best for you :)

-- 
Regards,
Igor.