[U-Boot] [PATCH] at91: Add support for Bluewater Systems Snapper 9G45 module

[Simon Glass]

Hi Reinhard,

On Sat, Oct 22, 2011 at 20:57, Reinhard Meyer <u-boot at emk-elektronik.de>wrote:

> Dear Simon Glass,
>
>> Snapper 9G45 is a ARM9-based CPU module with 1GB NAND and 128MB
>> DDR SDRAM. This patch includes NAND and Ethernet support.
>>
>> Signed-off-by: Simon Glass<sglass at bluewatersys.com>
>> ---
>>  board/bluewater/snapper9g45/**Makefile      |   43 +++++++
>>  board/bluewater/snapper9g45/**snapper9g45.c |  155
>> +++++++++++++++++++++++
>>  boards.cfg                                |    1 +
>>  include/configs/snapper9g45.h             |  189
>> +++++++++++++++++++++++++++++
>>  4 files changed, 388 insertions(+), 0 deletions(-)
>>  create mode 100644 board/bluewater/snapper9g45/**Makefile
>>  create mode 100644 board/bluewater/snapper9g45/**snapper9g45.c
>>  create mode 100644 include/configs/snapper9g45.h
>>
>> [...]
>>
>> +
>> +#ifndef NEW
>> +#define CONFIG_PCA953X
>> +#define CONFIG_SYS_I2C_PCA953X_ADDR    0x28
>> +#define CONFIG_SYS_I2C_PCA953X_WIDTH   { {0x28, 16} }
>> +#endif
>>
>
> if that is a board variant, use something better than just "NEW" -
> and where would that ever get defined?


Actually that can all be removed - will resubmit.


>
>
>  +/* Command line configuration */
>> +#include<config_cmd_default.**h>
>>
>
> Space missing here.
>

I don't see that missing space in my patch above - where did it come from?


> Please run checkpatch before submitting!
>

Yes I do this as part of patch submission, honest!

Regards,
Simon


>
> Best Regards,
> Reinhard
>
>