[U-Boot] [PATCH] dfu: initial implementation

[Andrzej Pietrasiewicz]

Hello Mike,

Thank you for your review. Please see my comments inline.

On Wednesday, November 02, 2011 4:16 PM Mike Frysinger wrote:

> >
> > Dear All,
> >
> > This is Device Firmware Upgrade (DFU) implementation which supports
> > data upload and download function to devices which are equipped with
> a UDC.
> 
> this information belongs in the changelog (above the "---" marker)
> 
I generally agree to remarks related to coding style and implementation's
distribution into respective patches.

> are you working with the elinux.org guys ?
> 	http://elinux.org/Merge_DFU_support_into_mainline_U-Boot
>
That's not me.

> 
> this should be split up into at least the dfu core and board-specific
> changes.
> although i'd wonder how much of the board/samsung/ stuff is really
> board specific and couldn't be generalized ...

You are right, probably the "flashing backend" part contains
some code which can be generalized.

Regards,

Andrzej