[U-Boot] [PATCH] drivers/net/ns8382x.c: fix GCC 4.6 build warnings

Wolfgang Denk wd at denx.de
Thu Nov 3 20:39:04 CET 2011


Dear Wolfgang Denk,

In message <1319917054-14002-1-git-send-email-wd at denx.de> you wrote:
> Fix:
> ns8382x.c: In function 'ns8382x_check_duplex':
> ns8382x.c:704:6: warning: variable 'hun' set but not used
> [-Wunused-but-set-variable]
> 
> To fix this, we get rid of the NS8382X_DEBUG code and use standard
> debug() instead.
> 
> This will now trigger a so far undetected warning:
> ns8382x.c:780:2: warning: format '%X' expects argument of type
> 'unsigned int', but argument 2 has type 'long unsigned int' [-Wformat]
> 
> Fix that, too.
> 
> Signed-off-by: Wolfgang Denk <wd at denx.de>
> ---
>  drivers/net/ns8382x.c |   85 +++++++++++++++++++++---------------------------
>  1 files changed, 37 insertions(+), 48 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I have often regretted my speech, never my silence.


More information about the U-Boot mailing list