[U-Boot] [PATCH] arch/powerpc/lib/board.c: fix build warning

Kim Phillips kim.phillips at freescale.com
Fri Nov 4 16:41:06 CET 2011


On Fri, 4 Nov 2011 01:47:04 -0500
Kumar Gala <galak at kernel.crashing.org> wrote:

> On Nov 4, 2011, at 1:44 AM, Kumar Gala wrote:
> > On Nov 3, 2011, at 2:09 PM, Wolfgang Denk wrote:
> >> In message <1319407132-6590-1-git-send-email-wd at denx.de> you wrote:
> >>> Commit 1272592 "powerpc: Use getenv_ulong() in place of getenv(),
> >>> strtoul" instroduced a build warning for some PPC systems:
> >>> 
> >>> board.c: In function 'board_init_r':
> >>> board.c:626: warning: unused variable 's'
> >>> 
> >>> Fix it.
> >>> 
> >>> Signed-off-by: Wolfgang Denk <wd at denx.de>
> >>> ---
> >>> arch/powerpc/lib/board.c |    5 +++--
> >>> 1 files changed, 3 insertions(+), 2 deletions(-)
> >> 
> >> Applied, thanks.
> > 
> > I'm still seeing this warning when building MPC8536DS_config

me too, on most 83xx boards.

> I think we need to revert this now.
> 
> I don't see why you'd need it.

yes, all code fragments that utilize a variable 's' declare one local
to their code body.

Kim



More information about the U-Boot mailing list