[U-Boot] [PATCH v2] [x86] Add a basic implementation for a coreboot board

Gabe Black gabeblack at chromium.org
Fri Nov 4 23:33:16 CET 2011


The early startup code is in arch/x86/cpu/start.S or start16.S depending on
the state of the CPU when u-boot is entered, and this code is called back
into at various points during startup. You can see that those callbacks
stubbed out where there's a label and then a jump back immediately after
it, for instance here:

+board_init16:
+       jmp     board_init16_ret

I have no problem merging the commits, but I'll wait for Graeme to weigh in
since it's a little easier to merge them than to unmerge them.

Gabe

On Fri, Nov 4, 2011 at 3:24 PM, Mike Frysinger <vapier at gentoo.org> wrote:

> i'm not terribly familiar with what it takes to make an x86 board, but i
> don't
> see anything jumping out of this patch.
>
> i would note however that you should merge the boards.cfg update into this
> patch.  merging one or the other doesn't make much sense, and there's no
> reason to keep them split.
>
> > +void setup_pcat_compatibility()
>
> should be "(void)"
> -mike
>


More information about the U-Boot mailing list