[U-Boot] [PATCH] [x86] Add a basic implementation for a coreboot board

[Wolfgang Denk]

Dear Gabe Black,

In message <1320439959-23095-1-git-send-email-gabeblack at chromium.org> you wrote:
>
...
> +void show_boot_progress(int val)
> +{
> +}

Drop the empty function, and don't enable the feature.

> +
> +

Don;t waste vertical space.  Please fix globally.

> +int last_stage_init(void)
> +{
> +	return 0;
> +}

Can we not avoind all these empty functions?

> +void setup_pcat_compatibility()
> +{
> +}

And again...

> +#ifdef CONFIG_HW_WATCHDOG
> +void hw_watchdog_reset(void)
> +{
> +}
> +#endif

And again.

NAK.  Please clean this up.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The best things in life are for a fee.