[U-Boot] [PATCH v2 6/8] tegra2: Implement SPI / UART GPIO switch

[Simon Glass]

Hi Mike,

On Thu, Nov 3, 2011 at 6:44 PM, Mike Frysinger <vapier at gentoo.org> wrote:
> On Thursday 03 November 2011 18:41:37 Simon Glass wrote:
>> Since we are adding a second file to board/nvidia/common, we create
>> a proper Makefile there and remove the direct board.o include from
>> board/nvidia/seaboard/Makefile
>
> so who is including board/nvidia/common/libnvidia.o now ?

No one - it doesn't exist and that directory doesn't have a Makefile.
The top-level Makefile doesn't require it, but since I now have more
than one object file I want to create a library.

>
>> --- /dev/null
>> +++ b/arch/arm/include/asm/arch-tegra2/uart-spi-switch.h
>>
>> +#ifndef __ASSEMBLY__
>
> the asm checking is incomplete.  so it must not matter -> drop it.

OK
>
>> --- /dev/null
>> +++ b/board/nvidia/common/uart-spi-switch.c
>>
>> +#include <asm/io.h>
>> +#include <libfdt.h>
>> +#include <fdt_support.h>
>
> seems to be unused
> -mike
>

OK - yes this isn't needed until FDT support is in there (will be a
later patch set).

Regards,
Simon