[U-Boot] [PATCH v0 1/4] Groundwork for generalization of env interface

[Wolfgang Denk]

Dear Gerlando Falauto,

In message <1319647072-17504-2-git-send-email-gerlando.falauto at keymile.com> you wrote:
> Signed-off-by: Gerlando Falauto <gerlando.falauto at keymile.com>
> ---
>  common/cmd_nvedit.c   |  152 +++++++++++++++++++++++++++++++------------------
>  common/env_common.c   |   15 ++++-
>  include/environment.h |    7 ++
>  include/search.h      |   13 ++++
>  lib/hashtable.c       |   50 ++++++++++++++++
>  5 files changed, 179 insertions(+), 58 deletions(-)
...
> -int _do_env_set (int flag, int argc, char * const argv[])
> +int env_check_apply(const char *name, const char *oldval,
> +		    const char *newval, int flag)

Please use only TAB for indentation.  Please fix globally.


> -	if (ep) {		/* variable exists */
> +	if ((oldval != NULL) /* variable exists */
> +	 && ((flag & H_FORCE) == 0)) { /* and we are not forced */

Incorrect indentation.


> +/*
> + * Set a new environment variable,
> + * or replace or delete an existing one.
> +*/

Incorrect multiline comment style.

> +	/* Perform requested checks. Notice how since we are overwriting
> +	 * a single variable, we need to set H_NOCLEAR */

Incorrect multiline comment style.

>  void set_default_env(const char *s)
>  {
> +	/* By default, do not apply changes as they will eventually
> +	 * be applied by someone else */

Incorrect multiline comment style.

Please fix globally!

> +	if (himport_ex(&env_htab, (char *)default_environment,
> +		    sizeof(default_environment), '\0', 0,
> +		      0, NULL, apply_function) == 0) {

Incorrect / inconsistent indentation.  Please fix globally.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Applying computer technology is simply finding the  right  wrench  to
pound in the correct screw.