[U-Boot] [PATCH v0 2/4] env: check and apply changes on delete/destroy

[Wolfgang Denk]

Dear Gerlando Falauto,

In message <1319647072-17504-3-git-send-email-gerlando.falauto at keymile.com> you wrote:
> Signed-off-by: Gerlando Falauto <gerlando.falauto at keymile.com>
> ---
>  common/cmd_nvedit.c |    2 +-
>  include/search.h    |    6 ++++--
>  lib/hashtable.c     |   18 ++++++++++++------
>  3 files changed, 17 insertions(+), 9 deletions(-)

Are you sure these changes are really independent from the previous
and following ones?  Ordo we introduc bisectability issues here?


> -extern void hdestroy_r(struct hsearch_data *__htab);
> +extern void hdestroy_r(struct hsearch_data *__htab,
> +		       apply_cb apply);

See provious comments - indentation always by TAB. Please fix
globally, i. e. in all your patches.


> +			if (apply != NULL) {
> +				/* deletion is always forced */

Um.... why is this the case?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
>  Is there a way to determine Yesterday's date using Unix utilities?
         echo "what is yesterday's date?" | /bin/mail root
         -- Randal L. Schwartz in <ukbuh2y982.fsf at julie.teleport.com>