[U-Boot] [PATCH v2 6/8] tegra2: Implement SPI / UART GPIO switch

[Simon Glass]

Hi Mike,

On Sat, Nov 5, 2011 at 10:11 AM, Mike Frysinger <vapier at gentoo.org> wrote:
> On Saturday 05 November 2011 10:43:07 Simon Glass wrote:
>> On Thu, Nov 3, 2011 at 6:44 PM, Mike Frysinger wrote:
>> > On Thursday 03 November 2011 18:41:37 Simon Glass wrote:
>> >> Since we are adding a second file to board/nvidia/common, we create
>> >> a proper Makefile there and remove the direct board.o include from
>> >> board/nvidia/seaboard/Makefile
>> >
>> > so who is including board/nvidia/common/libnvidia.o now ?
>>
>> No one - it doesn't exist and that directory doesn't have a Makefile.
>> The top-level Makefile doesn't require it, but since I now have more
>> than one object file I want to create a library.
>
> this patchset adds:
>  board/nvidia/common/Makefile                       |   47 +++++++
>
> which creates a libnvidia.o.  so once this patch is applied, how is
> libnvidia.o getting linked in ?
> -mike
>

There is a bit of the top-level Makefile which does this:

LIBS += $(shell if [ -f board/$(VENDOR)/common/Makefile ]; then echo \
	"board/$(VENDOR)/common/lib$(VENDOR).o"; fi)

but it is only activated if it sees a Makefile there. By adding it,
the library is created for me.

Regards,
Simon