[U-Boot] [PATCH 03/56] arch/powerpc/lib/board.c: make (mostly) checkpatch-clean

Wolfgang Denk wd at denx.de
Mon Nov 7 22:09:50 CET 2011


Dear Wolfgang Denk,

In message <1320458160-23136-4-git-send-email-wd at denx.de> you wrote:
> CodingStyle cleanup.
> 
> Accepted (in this cleanup) checkpatch messages:
> 
> - externs should be avoided
>   (to be cleaned up later)
> - no spaces at the start of a line
>   (accepted in multi-line #if's)
> - Macros with complex values
>   (false reports)
> - do not use assignment in if condition
>   (accepted in one place, where avoiding it would have required an
>   additional level of nesting, resulting in less readable code)
> 
> Signed-off-by: Wolfgang Denk <wd at denx.de>
> ---
>  arch/powerpc/lib/board.c |  455 ++++++++++++++++++++++++----------------------
>  1 files changed, 234 insertions(+), 221 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The moral of the story is: "Don't stop to  tighten  your  shoe  laces
during the Olympics 100m finals".
                             - Kevin Jones in <DEJo68.K1t at bri.hp.com>


More information about the U-Boot mailing list