[U-Boot] [PATCH v0 0/4] env: reworking + default/import individual vars
Gerlando Falauto
gerlando.falauto at keymile.com
Tue Nov 8 10:33:22 CET 2011
On 11/06/2011 11:15 PM, Wolfgang Denk wrote:
> Dear Gerlando Falauto,
>
> In
message<1319647072-17504-1-git-send-email-gerlando.falauto at keymile.com>
you wrote:
>> This is a resubmission (after removing remove checkpatch errors) of
>> http://lists.denx.de/pipermail/u-boot/2011-September/102875.html
>>
>> Here I am proposing a set of changes in the behaviour of the environment
>> import/set_to_default functions.
>>
>> PATCH 1:
>> Add a "new" himport_ex() function (reworking of himport_r which is now a
>> wrapper around it), which has 3 new arguments:
>>
>> "nvars", "vars":, number and list of variables to take into account
>> (0 means ALL)
>
> Hmmm.... I wonder how much testing you did.
I tested "env import" with and without -n. Same for "env default".
Also tested special variables.
> For me, env import is broken now.
I am not able to see how it's obviously broken.
Perhaps you mean that when you don't provide an argument to -n, the
following argument (e.g., -t) is interpreted as a variable name (and
therefore consumed)? That doesn't look like an error to me.
Could you please elaborate and/or provide a test case?
Thank you,
Gerlando Falauto
More information about the U-Boot
mailing list