[U-Boot] [PATCH v2 00/12] x86: Various cosmetic and minor code fixups
Graeme Russ
graeme.russ at gmail.com
Tue Nov 8 13:33:11 CET 2011
NOTE: Due to the way this patchset started life as a two-part series, the
threading may seem odd - Each patch is In-reply-to: the original patch
from the original corresponding series...
This series is the amalgamation of the 7 part 'Various x86 fixups' and 5 part
'x86: Cosmetic cleanup' patch sets
This series make x86 *.c files checkpatch clean except for:
- x86/cpu/interrupts.c has two function declarations which are picked up
as 'extern' - They should ideally be 'static', but the definition of
these functions are in macro'd inline assembler, so the compiler
complains that the functions are not defined is made static
- x86/lib/zimage.c has lines (just) over 80 characters caused by printf()
strings which, IMHO, would have reduced readability if split
- x86/lib/zimage.c has lines (just) over 80 characters which could be
fixed by converting the x86 zImage/bzImage header offsets into a
structure - This is a big change prone to the introduction of bugs and
will, therefore, be done later after the current x86 backlog stabilises
- x86/lib/zimage.c has "consider using kstrto* in preference to
simple_strtoul" warnings
Of the patches, patch 4 (cosmetic: checkpatch cleanup of arch/x86/lib/*.c)
has 23 checkpatch warnings all associated with asm statements which
checkpatch does not know how to deal with, and 3 'line over 80 characters'
warnings in x86/lib/zimage.c (see above)
Graeme Russ (12):
x86: Call hang() on unrecoverable exception
cosmetic: checkpatch cleanup of arch/x86/cpu/*.c
cosmetic: checkpatch cleanup of arch/x86/cpu/sc520/*.c
cosmetic: checkpatch cleanup of arch/x86/lib/*.c
cosmetic: checkpatch cleanup of board/eNET/*.c
x86: Punt cold- and warm-boot flags
sc520: Create arch asm-offsets
x86: Add multiboot header
x86: Provide more configuration granularity
x86: Ensure IDT and GDT remain 16-byte aligned post relocation
x86: Misc PCI touchups
x86: Misc cleanups
arch/x86/cpu/cpu.c | 22 ++--
arch/x86/cpu/interrupts.c | 53 +++++----
arch/x86/cpu/sc520/asm-offsets.c | 45 +++++++
arch/x86/cpu/sc520/sc520.c | 2 +-
arch/x86/cpu/sc520/sc520_car.S | 3 +-
arch/x86/cpu/sc520/sc520_pci.c | 28 +++--
arch/x86/cpu/sc520/sc520_sdram.c | 53 --------
arch/x86/cpu/sc520/sc520_ssi.c | 43 ++++----
arch/x86/cpu/sc520/sc520_timer.c | 4 +-
arch/x86/cpu/start.S | 30 ++++-
arch/x86/cpu/start16.S | 3 -
arch/x86/include/asm/arch-sc520/sc520.h | 26 ----
arch/x86/include/asm/global_data.h | 21 ----
arch/x86/include/asm/pci.h | 5 +-
arch/x86/include/asm/realmode.h | 4 +
arch/x86/include/asm/u-boot-x86.h | 8 ++
arch/x86/lib/Makefile | 18 ++--
arch/x86/lib/bios.h | 201 ++++++++++++++++++++++---------
arch/x86/lib/bios_pci.S | 92 ++++++++++-----
arch/x86/lib/bios_setup.c | 93 +++------------
arch/x86/lib/board.c | 140 ++++++++++++----------
arch/x86/lib/bootm.c | 27 +++--
arch/x86/lib/interrupts.c | 20 ++--
arch/x86/lib/pcat_interrupts.c | 2 +-
arch/x86/lib/pcat_timer.c | 37 +++---
arch/x86/lib/pci.c | 99 +++++++++++-----
arch/x86/lib/pci_type1.c | 13 ++-
arch/x86/lib/realmode.c | 20 ++--
arch/x86/lib/timer.c | 16 ++--
arch/x86/lib/video.c | 6 +-
arch/x86/lib/video_bios.c | 130 ++++++++------------
arch/x86/lib/zimage.c | 94 ++++++++-------
board/eNET/eNET.c | 8 +-
board/eNET/eNET_pci.c | 19 ++--
board/eNET/eNET_start16.S | 5 +-
common/cmd_bdinfo.c | 3 +-
include/configs/eNET.h | 5 +
37 files changed, 739 insertions(+), 659 deletions(-)
create mode 100644 arch/x86/cpu/sc520/asm-offsets.c
--
1.7.5.2.317.g391b14
More information about the U-Boot
mailing list