[U-Boot] [PATCH 0/3] ARM: vexpress: add support for A5 core tile

[Ryan Harkin]

Hi Albert,

Thanks for looking at my patches.

I'm not sure exactly what you mean, so I'll explain that I am doing
here and see if that help resolve the issue you are seeing, if not,
hopefully you'll have more info to help clarify.

The first patch is simply moving and renaming files in preparation for
me adding A5 support in a later patch.  So, the ca9x4_ct_vxp platform
is renamed to vexpress_common.  You can still build it, it's just
named "funny".  You would build it with "make ...
vexpress_common_config".  I did this because I wanted the first patch
to only contain file moves and renames without changing any code, in
the hope that it would be easier to review.  Perhaps I failed in that
goal!

The next patch then adds a new config file so that the board is named
as the more friendly vexpress_ca9x4 and you can no longer build a
vexpress_common board.

The final patch then adds a further config for A5 and makes some
changes for the RS1 memory map.

I hope this clarifies what I've done.  Please ask more questions or
make suggestions to help improve my patch sequence.

Regards,
Ryan.

On 5 November 2011 05:57, Albert ARIBAUD <albert.u.boot at aribaud.net> wrote:
> Le 18/10/2011 14:41, Ryan Harkin a écrit :
>>
>> Add support for the A5 Core Tile on the Versatile Express motherboard.
>>
>> Ryan Harkin (3):
>>   ARM: vexpress: move files in preparation for adding a new platform
>>   ARM: vexpress: create A9 specific board config
>>   ARM: vexpress: create A5 specific board config
>>
>>  MAINTAINERS                                        |    3 +-
>>  board/armltd/vexpress/Makefile                     |    2 +-
>>  .../vexpress/{ca9x4_ct_vxp.c =>  vexpress_common.c} |   29 ++-
>>  boards.cfg                                         |    3 +-
>>  include/configs/ca9x4_ct_vxp.h                     |  206 -------------
>>  include/configs/vexpress_ca5x2.h                   |   34 +++
>>  include/configs/vexpress_ca9x4.h                   |   34 +++
>>  include/configs/vexpress_common.h                  |  314
>> ++++++++++++++++++++
>>  8 files changed, 410 insertions(+), 215 deletions(-)
>>  rename board/armltd/vexpress/{ca9x4_ct_vxp.c =>  vexpress_common.c} (90%)
>>  delete mode 100644 include/configs/ca9x4_ct_vxp.h
>>  create mode 100644 include/configs/vexpress_ca5x2.h
>>  create mode 100644 include/configs/vexpress_ca9x4.h
>>  create mode 100644 include/configs/vexpress_common.h
>
> The series is not bisectable in that board ca9x4_ct_vxp disappears in patch
> 1/3 to reappear in patch 2/3. Please reorganize patch set so that common
> files are extracted without preventing ca9x4_ct_vxp from building.
>
> Amicalement,
> --
> Albert.
>