[U-Boot] [PATCH] mvgbe: remove setting of ethaddr within the driver

Wolfgang Denk wd at denx.de
Tue Nov 8 16:17:36 CET 2011


Dear "Michael Walle",

In message <89e599b8867346f857ae2f132e9717a3.squirrel at ssl.serverraum.org> you wrote:
>
> >> +#define CONFIG_ETH_ADDR 02:50:43:00:00:01
> >
> > NAK to this.  board configs are not allow to hardcode MACs.
> mh, so why is there a CONFIG_ETH_ADDR macro? is it deprecated?
> README.enetaddr explicitly refers to that config option.

There are situations where it cannot be helped, like when programming
the U-Boot image into a ROM (yes, a real ROM that cannot be changed
any more by software alone).

But in almost all normal situations this must not be used.  In any
case, we will not accept it into mainline.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Be kind to unkind people - they need it the most.


More information about the U-Boot mailing list