[U-Boot] [PATCH v2] x86: Import the glibc memset implementation

[Graeme Russ]

Hi Gabe,

first up - Please stop top-posting

On Wed, Nov 9, 2011 at 11:59 AM, Gabe Black <gabeblack at chromium.org> wrote:
> I'm pretty sure u-boot doesn't link with glibc. I'd expect that to cause all
> sorts of problems on top of being really big. There are default, generic
> implementations which it can use, or you can specialize them to take
> advantage of architecture specific features like I'm doing here.

Hmm,

# Add GCC lib
ifdef USE_PRIVATE_LIBGCC
ifeq ("$(USE_PRIVATE_LIBGCC)", "yes")
PLATFORM_LIBGCC = $(OBJTREE)/arch/$(ARCH)/lib/libgcc.o
else
PLATFORM_LIBGCC = -L $(USE_PRIVATE_LIBGCC) -lgcc
endif
else
PLATFORM_LIBGCC := -L $(shell dirname `$(CC) $(CFLAGS)
-print-libgcc-file-name`) -lgcc
endif
PLATFORM_LIBS += $(PLATFORM_LIBGCC)
export PLATFORM_LIBS

So we link with libgcc - In another email I raise the question of why
regparm is not conflicting here

And why do we have an option to not link to libgcc, but on the other
hand we never link to libc - I'm confused

Regards,

Graeme

> On Tue, Nov 8, 2011 at 4:45 PM, Graeme Russ <graeme.russ at gmail.com> wrote:
>>
>> Hi Gabe,
>>
>>
>> On Wed, Nov 9, 2011 at 9:40 AM, Gabe Black <gabeblack at chromium.org> wrote:
>> > The new implementation is about twice as fast as the old.
>> >
>>
>> I don't get it - If this is the glibc implementation, we aren't we just
>> using the implementation in the glibc library which we link to?
>>
>> Regards,
>>
>> Graeme
>
>