[U-Boot] [PATCH v2] x86: Import the glibc memset implementation

[Graeme Russ]

Hi Gabe,

[snip]

> From what I understand, USE_PRIVATE_LIBGCC was introduced because some
> compilers/linkers have ABI compatibility issue (someone more familiar with
> the history may be able to correct me) - This sounds _exactly_ what we
> have here with x86 - x86 has an ABI incompatibility by using reparm(3).
> I think reparm was used to simplify some asm/C interfaces - maybe these
> can be re-coded and we can drop regparm and we can drop the wrappers.

My commit 5c161653db3aa585f3e47a650ae177ba9ffb7232 (7 Oct 2010)
introduced reparam to reduce code size and increase speed

> Alternatively, I think I would prefer to use USE_PRIVATE_LIBGCC instead of
> the wrappers as this highlights that U-Boot is _not_ ABI compliant and
> therefore cannot link to libgcc. I can just see someone in the future
> using a libgcc function and not implementing a wrapper and doing a lot of
> head scratching when things wrong...

I think we should ditch reparam and partially revert what the above commit did

Regards,

Graeme