[U-Boot] [PATCH] arm, davinci_emac: fixup
Wolfgang Denk
wd at denx.de
Wed Nov 9 07:51:19 CET 2011
Dear Heiko Schocher,
In message <1320819979-3861-1-git-send-email-hs at denx.de> you wrote:
...
> + if (count < MAX_PHY)
> + active_phy_addr[j++] = i;
> + else {
> + printf("%s: to much PHYs detected.\n",
> + __func__);
> + break;
> + }
Coding Style: if the "else" branch uses braces, the "if" branch shall
use braces, too.
Also, please s/too much/too many/ in the printf() above.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Be kind to unkind people - they need it the most.
More information about the U-Boot
mailing list