[U-Boot] [PATCH 11/13] drivers/video/ct69000.c: Fix GC 4.6 build warning

Wolfgang Denk wd at denx.de
Thu Nov 10 06:43:54 CET 2011


Dear Mike Frysinger,

In message <201111091544.17111.vapier at gentoo.org> you wrote:
>
> >  #undef VGA_DEBUG
> >  #undef VGA_DUMP_REG
> >  #ifdef VGA_DEBUG
> > -#define	PRINTF(fmt,args...)	printf (fmt ,##args)
> > +#undef _DEBUG
> > +#define _DEBUG  1
> >  #else
> > -#define PRINTF(fmt,args...)
> > +#undef _DEBUG
> > +#define _DEBUG  0
> >  #endif
> 
> so do you still need this ?  since you've converted to debug(), looks like
> this logic can all go away.

It's needed if I want to keep the original behaviour regarding
VGA_DEBUG and VGA_DUMP_REG which were independent before.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The more we disagree, the more chance there is that at least  one  of
us is right.


More information about the U-Boot mailing list