[U-Boot] [PATCH] arm, davinci: make arch_cpu_init() in da850_lowlevel.c weak

[Christian Riesch]

Hello Heiko,

On Wed, Nov 9, 2011 at 1:18 PM, Heiko Schocher <hs at denx.de> wrote:
> Christian Riesch wrote:
>>  332         lpsc_on(DAVINCI_LPSC_UART2);
>>  333         NS16550_init((NS16550_t)(CONFIG_SYS_NS16550_COM1),
>>  334                         CONFIG_SYS_NS16550_CLK / 16 / CONFIG_BAUDRATE);
>>  335
>>  336         /*
>>  337          * Fix Power and Emulation Management Register
>>  338          * see sprufw3a.pdf page 37 Table 24
>>  339          */
>>  340         writel(readl((CONFIG_SYS_NS16550_COM1 + 0x30)) | 0x00006001,
>>  341                 (CONFIG_SYS_NS16550_COM1 + 0x30));
>>
>> I guess this is only needed for debugging the SPL?
>
> This must be done before using the uart as a console, and I think
> this should be done in common code as early as possible.

Yes, but it will also be done later in serial_init() called from
board_init_f(), right? So this is only a hack to allow debug messages
at this stage before it is done properly in serial_init(). Am I
missing something here?
Regards, Christian