[U-Boot] [PATCH v2 2/2] ARM:AM33XX:Added cpsw support for AM335x EVM
Kumar Nath, Chandan
chandan.nath at ti.com
Thu Nov 10 16:05:22 CET 2011
> -----Original Message-----
> From: Tom Rini [mailto:tom.rini at gmail.com]
> Sent: Thursday, November 10, 2011 8:17 PM
> To: Kumar Nath, Chandan
> Cc: u-boot at lists.denx.de
> Subject: Re: [U-Boot] [PATCH v2 2/2] ARM:AM33XX:Added cpsw support for
> AM335x EVM
>
> On Thu, Nov 10, 2011 at 5:40 AM, Chandan Nath <chandan.nath at ti.com>
> wrote:
> > This patch adds cpsw support on AM335X EVM.
> >
> > Signed-off-by: Chandan Nath <chandan.nath at ti.com>
>
> You aren't allowed to have hard-coded MACs anymore, iirc. And
> everyone will be able to get valid MACs from the e-fuse (or on the
> other platforms, EEPROM), we need to drop that particular debug print
> and just fail when ethaddr isn't set. So you can drop the
> ..set_mac_addr function, and fold the rest of the changes to cpsw.c
> into the original patch. Finally, please split the miiphyutil.c
> change into its own commit. Thanks.
>
I will remove the debug print and return failure when ethaddr is not set.
I have already remove cpsw_eth_set_mac_addr function from cpsw.c and pushed
to the original patch.
I will split miiphyutil.c changes in to a separate patch.
> --
> Tom
More information about the U-Boot
mailing list