[U-Boot] [PATCH v2 1/2] TI: netdev: add driver for cpsw ethernet device

Tom Rini tom.rini at gmail.com
Thu Nov 10 17:39:49 CET 2011


On Thu, Nov 10, 2011 at 9:26 AM, Mike Frysinger <vapier at gentoo.org> wrote:
> On Thursday 10 November 2011 07:40:28 Chandan Nath wrote:
>> +#define mac_hi(mac)    (((mac)[0] << 0) | ((mac)[1] << 8) |    \
>> +                        ((mac)[2] << 16) | ((mac)[3] << 24))
>
> looks like __get_unaligned_u32()
>
>> +#define mac_lo(mac)    (((mac)[4] << 0) | ((mac)[5] << 8))
>
> looks like __get_unaligned_u16()

It's the regular MAC shifting around everyone does.  Are you saying
there's a general cleanup to be done here?

-- 
Tom


More information about the U-Boot mailing list