[U-Boot] [PATCH v2] powerpc/83xx: fix sdram initialization for keymile boards

Kim Phillips kim.phillips at freescale.com
Sat Nov 12 00:10:59 CET 2011


On Thu, 10 Nov 2011 10:36:18 -0600
Kim Phillips <kim.phillips at freescale.com> wrote:

> On Thu, 10 Nov 2011 15:52:43 +0100
> Holger Brunck <holger.brunck at keymile.com> wrote:
> 
> > From: Andreas Huber <andreas.huber at keymile.com>
> > 
> > commit b11f53f3 (keymile: Fix Coding style issues for keymile boards)
> > introduces a bug according the SDRAM initialization for all
> > km83xx boards.
> > 
> > im->ddr.sdram_cfg |= SDRAM_CFG_MEM_EN;
> > was replaced with
> > out_be32(&im->ddr.sdram_cfg, SDRAM_CFG_MEM_EN);
> > and this is wrong, because this overwrites the intial value
> > CONFIG_SYS_DDR_SDRAM_CFG.
> > 
> > Signed-off-by: Andreas Huber <andreas.huber at keymile.com>
> > Signed-off-by: Holger Brunck <holger.brunck at keymile.com>
> > Acked-by: Heiko Schocher <hs at denx.de>
> > cc: Kim Phillips <kim.phillips at freescale.com>
> > ---
> 
> good catch.
> 
> Acked-by: Kim Phillips <kim.phillips at freescale.com>

Just noticed this can go through 83xx, so I've applied it to
mpc83xx/master.

Kim



More information about the U-Boot mailing list