[U-Boot] [PATCH v2 04/12] cosmetic: checkpatch cleanup of arch/x86/lib/*.c

Graeme Russ graeme.russ at gmail.com
Sat Nov 12 11:06:50 CET 2011


On 08/11/11 23:33, Graeme Russ wrote:
> Signed-off-by: Graeme Russ <graeme.russ at gmail.com>
> ---
> Changes for v2:
>  - Consolidated patch series
>  - Fixed more warnings
> 
> This patch has 23 checkpatch errors all associated with asm statements
> which checkpatch does not know how to deal with
> 
> This patch has 3 checkpatch warnings, all of which are 'line over 80
> characters' which:
> 
>  - One is caused by printf() strings which, IMHO, would have reduced
>    readability if split
> 
>  - Two are due to calculations which could be shortened by converting the
>    x86 zImage/bzImage header offsets into a structure (which should be done
>    on principle anyway) - This is a big change prone to the introduction of
>    bugs and will, therefore, be done later after the current x86 backlog
>    stabilises
> 
>  arch/x86/include/asm/pci.h        |    3 +
>  arch/x86/include/asm/realmode.h   |    4 +
>  arch/x86/include/asm/u-boot-x86.h |    8 ++
>  arch/x86/lib/bios.h               |  201 ++++++++++++++++++++++++++-----------
>  arch/x86/lib/bios_pci.S           |   92 ++++++++++++------
>  arch/x86/lib/bios_setup.c         |   93 +++--------------
>  arch/x86/lib/board.c              |  114 ++++++++++-----------
>  arch/x86/lib/bootm.c              |   23 ++--
>  arch/x86/lib/interrupts.c         |   20 ++--
>  arch/x86/lib/pcat_interrupts.c    |    2 +-
>  arch/x86/lib/pcat_timer.c         |   37 ++++----
>  arch/x86/lib/pci.c                |   63 ++++++------
>  arch/x86/lib/pci_type1.c          |    9 +-
>  arch/x86/lib/realmode.c           |   20 ++--
>  arch/x86/lib/timer.c              |   16 ++--
>  arch/x86/lib/video.c              |    6 +-
>  arch/x86/lib/video_bios.c         |  143 +++++++++++++++------------
>  arch/x86/lib/zimage.c             |   94 ++++++++++--------
>  18 files changed, 516 insertions(+), 432 deletions(-)

Applied to u-boot-x86

Thanks,

Graeme



More information about the U-Boot mailing list