[U-Boot] [PATCH v3] x86: Import the glibc memset implementation

[Graeme Russ]

Hi Gabe,

Sorry about the lateness, but I just noticed a couple of issues..

Can you put the glibc version in the patch summary? I know it is in
string.c, but including it in the summary makes it more obvious.

On 13/11/11 14:00, Gabe Black wrote:
> The new implementation is about twice as fast as the old.
> 
> Signed-off-by: Gabe Black <gabeblack at chromium.org>
> ---
[snip]

> diff --git a/arch/x86/lib/string.c b/arch/x86/lib/string.c
> new file mode 100644
> index 0000000..1346173
> --- /dev/null
> +++ b/arch/x86/lib/string.c
> @@ -0,0 +1,87 @@
> +/*
> + * Copyright (C) 1991,1992,1993,1997,1998,2003, 2005 Free Software Foundation, Inc.

Line over 80 characters - I can live with this as it is a verbatim import

> + * This file is part of the GNU C Library.
> + * Copyright (c) 2011 The Chromium OS Authors. All rights reserved.

This, however, causes a problem - There is some conjecture as to whether
"All rights reserved" can co-exist with GPL. I believe there is a mandate
from Wolfgang to not accept patches with this clause - Do I understand
correctly Wolfgang?

Regards,

Graeme