[U-Boot] [PATCH 3/5] mx5: add generic USB EHCI support for mx51 and mx53

Wolfgang Grandegger wg at grandegger.com
Mon Nov 14 09:39:32 CET 2011


On 11/11/2011 03:22 PM, Fabio Estevam wrote:
> Hi Wolfgang,
> 
> On Fri, Nov 11, 2011 at 11:03 AM, Wolfgang Grandegger <wg at denx.de> wrote:
>> It's derived from ehci-mxc and uses the header files of the
>> ehci-fsl interface. The callback board_ehci_hcd_init() has
>> been introduced to allow for board-specific setup when USB
>> is started.
>>
>> Signed-off-by: Wolfgang Grandegger <wg at denx.de>
>> CC: Stefano Babic <sbabic at denx.de>
>> CC: Remy Bohmer <linux at bohmer.net>
>> ---
>>  drivers/usb/host/Makefile   |    1 +
>>  drivers/usb/host/ehci-mx5.c |  174 +++++++++++++++++++++++++++++++++++++++++++
>>  include/usb/ehci-fsl.h      |   10 +++
>>  3 files changed, 185 insertions(+), 0 deletions(-)
>>  create mode 100644 drivers/usb/host/ehci-mx5.c
> 
> Do we really need  to create a drivers/usb/host/ehci-mx5.c?
> 
> Can't mx5 USB support be included inside drivers/usb/host/ehci-mxc.c instead?

it could be included into ehci-mxc.c using #ifdef's, of course. Would
that be the better solution?

Wolfgang.


More information about the U-Boot mailing list