[U-Boot] [PATCH 0/5] mx5: USB host support for mx51evk and mx53loco

[Wolfgang Grandegger]

Hi Jana,

On 11/12/2011 12:34 AM, Jana Rapava wrote:
>> This patches series provides USB host support for the mx51evk and
>> mx53loco. The generic ehci-mx5 interface is derived from ehci-mxc
>> and uses the header files of the ehci-fsl interface. The callback
>> board_ehci_hcd_init() allows to do board-specific setup when USB is
>> started.
>>
>> Wolfgang.
>>
>> Wolfgang Grandegger (5):
>>   mx5: add helper functions to enable USB clocks
>>   mx5: add helper function to retrieve the GPIO number
>>   mx5: add generic USB EHCI support for mx51 and mx53
>>   mx53loco: add end enable USB host support on port 1
>>   mx51evk: add end enable USB host support on port 1
>>
>>  arch/arm/cpu/armv7/mx5/clock.c            |   72 ++++++++++++
>>  arch/arm/include/asm/arch-mx5/clock.h     |    5 +
>>  arch/arm/include/asm/arch-mx5/crm_regs.h  |    3 +
>>  arch/arm/include/asm/arch-mx5/mx5x_pins.h |    4 +
>>  board/freescale/mx51evk/mx51evk.c         |   92 +++++++++++++++
>>  board/freescale/mx53loco/mx53loco.c       |   10 ++
>>  drivers/usb/host/Makefile                 |    1 +
>>  drivers/usb/host/ehci-mx5.c               |  174
>> +++++++++++++++++++++++++++++ include/configs/mx51evk.h                 | 
>>  13 ++
>>  include/configs/mx53loco.h                |   13 ++
>>  include/usb/ehci-fsl.h                    |   10 ++
>>  11 files changed, 397 insertions(+), 0 deletions(-)
>>  create mode 100644 drivers/usb/host/ehci-mx5.c
> 
> Hi, I'm working on MX51 USB support based on some patches from Marek Vasut. 
> It solves the problem in another way (uses structure-based offsets and generic
> ULPI implementation I've written for this) and is probably more polished because
> it's spent in the mailing list something like 2 months.

The structure-based offsets are nice. For my boards I do not need
special ULPI support and therefore it's a clearly separated interface.

> However, your patch supports both mx51 and mx53, so I think it would be nice
> to find some way to get them together.

I think we should share some code, especially the ehci_hcd_init()
callback. If my recent patch series, I call a board-specific
board_hcd_init() in the common ehci_hcd_init() which would be fine for
your hardware as well.

> Last but not least, I'm sorry that I didn't respond to your first e-mail,
> but I had to study for a test and hadn't time to look at your patch better.

No problem, you are welcome.

Unfortuantely, the existing interface ehci for the mxc is kind of mess
and if derived from various existing interfaces, mainly ehci-fsl from
u-boot and ehci-mxc from linux.

I'm going to comment on your recent patch series now...

Wolfgang.