[U-Boot] [PATCH V2] BOOT: Add "bootz" command to boot Linux zImage

[Marek Vasut]

> Marek Vasut wrote at Friday, November 11, 2011 7:51 PM:
> > This command boots Linux zImage from where the zImage is loaded to.
> > Passing initrd and fdt is supported.
> 
> Marek, this looks pretty neat. A few general questions though:
> 
> 1) I believe the zImage format is ARCH-specific. I'm not sure that on
> non-ARM ARCHs, you just start executing at the start of the zImage. Should
> this function be somehow disabled on non-ARM until something explicit is
> done about that?

Well zImage contains the decompressor which handles the proper placement of the 
kernel. Therefore there is only the catch the user must not be an idiot and must 
load the kernel at the correct address himself.

> 
> 2) Should bootz_start() validate it was passed a valid zImage, by checking
> the magic value in the header?

Sounds good.

> 
> 3) boot_get_ramdisk() only accepts uImage (legacy or FIT). Can/should it
> be enhanced to accept raw ramdisk images?

Certainly, that'd help. Are you willing to look into that?

> 
> 4) Is it safe to assume that do_bootm_linux() only cares about images->ep
> and nothing else for the kernel? I know it's coded that way right now,
> but I wonder if someone might refactor bootm and forget about bootz and
> change this assumption. I guess this is OK though...

Yes, this is valid point. We should be very careful about this. So suggestions 
how to handle this ?

> 
> I don't have any other specific comments on the code.
> 
> You may want to CC everyone else involved in the IH_TYPE_KERNEL_NOLOAD
> discussion - I imagine they'll all be interested in this too.

Sure.
> 
> --
> nvpublic