[U-Boot] [PATCH 0/2] omap3evm: Add support for EFI partitions

[Premi, Sanjeev]

> -----Original Message-----
> From: Tom Rini [mailto:tom.rini at gmail.com] 
> Sent: Monday, November 14, 2011 9:05 PM
> To: Premi, Sanjeev
> Cc: u-boot at lists.denx.de
> Subject: Re: [U-Boot] [PATCH 0/2] omap3evm: Add support for 
> EFI partitions
> 
> On Mon, Nov 14, 2011 at 8:19 AM, Sanjeev Premi <premi at ti.com> wrote:
> > After enabling CONFIG_EFI_PARTITION, following errors were
> > noticed.
> >
> > part_efi.c: In function 'print_part_efi':
> > part_efi.c:133:5: warning: passing argument 3 of 'is_gpt_valid'
> >  from incompatible pointer type
> > part_efi.c:95:12: note: expected 'struct gpt_header *' but arg
> > ument is of type 'struct gpt_header **'
> > part_efi.c: In function 'get_partition_info_efi':
> > part_efi.c:173:4: warning: passing argument 3 of 'is_gpt_valid
> > ' from incompatible pointer type
> > part_efi.c:95:12: note: expected 'struct gpt_header *' but arg
> > ument is of type 'struct gpt_header **'
> > part_efi.c: In function 'alloc_read_gpt_entries':
> > part_efi.c:384:18: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclar
> > ed (first use in this function)
> > part_efi.c:384:18: note: each undeclared identifier is reporte
> > d only once for each function it appears in
> > make[1]: *** [part_efi.o] Error 1
> > make[1]: Leaving directory `/db/psp_git/users/a0756819/u-boot/
> > disk'
> > make: *** [disk/libdisk.o] Error 2
> 
> Is there a reason EFI doesn't use ARCH_DMA_MINALIGN ?

I have no idea, but use of CONFIG_SYS_CACHELINE_SIZE in part_efi.c
was introduced in:

commit f75dd584cdfe29dfdcfd424bb237b9238cfb8fe4
Author: Anton staaf <robotboy at chromium.org>
Date:   Wed Oct 12 13:56:04 2011 +0000

~sanjeev

> 
> -- 
> Tom
>