[U-Boot] [PATCH 2/3 v2] devkit3250: add Timll DevKit3250 board initial support

[Vladimir Zapolskiy]

Hi Igor,

On 15.11.2011 08:42, Igor Grinberg wrote:
> Hi Vladimir,
>
> On 11/14/11 19:43, Vladimir Zapolskiy wrote:
>> This change adds a basic support for Embest/Timll DevKit3250 board,
>> NOR and UART are the only supported peripherals for a moment. The board
>> doesn't require low-level init, because the initial SDRAM and GPIO
>> configuration is performed during kickstart bootloader execution.
>>
>> Signed-off-by: Vladimir Zapolskiy<vz at mleia.com>
>> ---
>> Changes from v1 to v2:
>> * corrected address in GPLv2+ licence header in files
>
> I think you should remove the address part completely,
> because next time it changes, will you be around to fix it?
I promise I'll be around, that's why I desire to become a maintainer of 
this board.

> I know that there are many files already with address, but
> to make a big change it is better to start it from small -
> say all new coming patches.
Well, my small contribution is verifying address in license header found 
in new files.

I'd like to invite Wolfgang into discussion to get his opinion about the 
topic. Well, I do not feel myself as a lawer to allege that removing 
address info from the license notice is ok. Has it already been 
discussed in the mailing list?

>> * removed clean and distclean targets from board makefile
>> * do not set machine id explicitly, if CONFIG_MACH_TYPE is defined
>> * minor indentation cleanups
>>
>>   board/timll/devkit3250/Makefile     |   44 +++++++++++++
>>   board/timll/devkit3250/devkit3250.c |   71 ++++++++++++++++++++
>>   boards.cfg                          |    3 +-
>>   include/configs/devkit3250.h        |  121 +++++++++++++++++++++++++++++++++++
>>   4 files changed, 238 insertions(+), 1 deletions(-)
>>   create mode 100644 board/timll/devkit3250/Makefile
>>   create mode 100644 board/timll/devkit3250/devkit3250.c
>>   create mode 100644 include/configs/devkit3250.h
>>

[snip]

-- 
With best wishes,
Vladimir