[U-Boot] [PATCH 2/6] i.mx: Add the initial support for freescale i.MX6Q processor

[Jason Hui]

On Mon, Nov 14, 2011 at 7:49 PM, Stefano Babic <sbabic at denx.de> wrote:
> On 11/14/2011 10:42 AM, Jason Hui wrote:
>
>>>
>>> All get_usdhcX function are identical, except for two masks
>>> (MXC_CCM_CSCDR1_USDHCx_PODF_MASK and MXC_CCM_CSCMR1_USDHCx_CLK_SEL).
>>> Merge them in a get_usdhc_clk(usdhc_number)
>>
>>
>> Yes, I'm using mxc_ccm_reg.
>
> Ok - this structure is also used in most drivers - if I am not wrong
> (and I will better check), the struct clkctl is used only to generate
> the offsets in asm-offsets.h. If it is so, it could be drop in a future
> clean up patch...

Yes, agree!

>
>>> Maybe do we find a way to add a common include directory ? This file is
>>> duplicated. We can use include/asm/arch/imx-common
>>
>> I don't find one good way to add a common include directory. If I try
>> to find one,
>> I will put this head file to imx-common.
>
> The easy way is to add include/asm/arch-imx-common, and then the header
> are explicitely included as #include <asm/arch-imx-common/..>.
> I have seen only another example in U-Boot for armv7:
>
> arch/arm/cpu/armv7/highbank/timer.c:#include <asm/arch-armv7/systimer.h>
>
> I am opened to other solutions, too, but I think that introducing a
> common repository for IMX include files (as Linux with plat_imx does) is
> the way to do.

ok,  thanks for the review.

>
> Best regards,
> Stefano Babic
>
> --
> =====================================================================
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
> =====================================================================
>