[U-Boot] [PATCH v2 2/2] smsc95xx: Debug message cleanup

Simon Glass sjg at chromium.org
Wed Nov 16 00:22:30 CET 2011


On Tue, Nov 15, 2011 at 1:19 AM, Wolfgang Grandegger <wg at denx.de> wrote:
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Mike Frysinger <vapier at gentoo.org>
> Signed-off-by: Wolfgang Grandegger <wg at denx.de>
> ---
>  drivers/usb/eth/smsc95xx.c |   10 +++-------
>  1 files changed, 3 insertions(+), 7 deletions(-)

Acked-by: Simon Glass <sjg at chromium.org>

>
> diff --git a/drivers/usb/eth/smsc95xx.c b/drivers/usb/eth/smsc95xx.c
> index b5626e6..2f63340 100644
> --- a/drivers/usb/eth/smsc95xx.c
> +++ b/drivers/usb/eth/smsc95xx.c
> @@ -380,18 +380,14 @@ static int smsc95xx_write_hwaddr(struct eth_device *eth)
>        /* set hardware address */
>        debug("** %s()\n", __func__);
>        ret = smsc95xx_write_reg(dev, ADDRL, addr_lo);
> -       if (ret < 0) {
> -               debug("Failed to write ADDRL: %d\n", ret);
> +       if (ret < 0)
>                return ret;
> -       }
>
>        ret = smsc95xx_write_reg(dev, ADDRH, addr_hi);
>        if (ret < 0)
>                return ret;
> -       debug("MAC %02x:%02x:%02x:%02x:%02x:%02x\n",
> -               eth->enetaddr[0], eth->enetaddr[1],
> -               eth->enetaddr[2], eth->enetaddr[3],
> -               eth->enetaddr[4], eth->enetaddr[5]);
> +
> +       debug("MAC %pM\n", eth->enetaddr);
>        dev->have_hwaddr = 1;
>        return 0;
>  }
> --
> 1.7.4.1
>
>


More information about the U-Boot mailing list