[U-Boot] [PATCH] env: allow to export only selected variables

Wolfgang Denk wd at denx.de
Thu Nov 17 20:18:18 CET 2011


Dear Gerlando Falauto,

In message <4EC55B4F.4060007 at keymile.com> you wrote:
> 
> >   ssize_t hexport_r(struct hsearch_data *htab, const char sep,
> > -		 char **resp, size_t size)
> > +		 char **resp, size_t size,
> > +		 int argc, char * const argv[])
> >   {
> >   	ENTRY *list[htab->size];
> >   	char *res, *p;
> 
> What happened to "please indent with TABs only"?
> Have I missed something, perhaps?

Yes, you missed this error in the initial code review :-)

[Unfortunaltely I haven't found yet a way to convince Lindent or
similar to use only TABs in places like that. Hints welcome.]

Please feel free to submit cleanup-patches.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Wenn das dann in die Hose geht, nehme ich es auf meine Kappe.
                                         -- Rudi Völler, 15. Nov 2003


More information about the U-Boot mailing list